feat(vehicle_cmd_gate): improve debug marker activation #5426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 1222-takeshi <[email protected]>
Signed-off-by: 1222-takeshi <[email protected]>
Signed-off-by: 1222-takeshi <[email protected]>
Signed-off-by: 1222-takeshi <[email protected]>
github-actions
bot
added
type:documentation
Merged
7 tasks
1222-takeshi
changed the title
1222-takeshi
changed the title
1222-takeshi
force-pushed
the
feat/improve-filter-marker
branch
from
bfb8191 to
c4fab1f
Compare
Signed-off-by: 1222-takeshi <[email protected]>
1222-takeshi
force-pushed
the
feat/improve-filter-marker
branch
from
c4fab1f to
83382d6
Compare
tkimura4
reviewed
Oct 30, 2023
Signed-off-by: 1222-takeshi <[email protected]>
tkimura4
added
the
run:build-and-test-differential
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5426 +/- ##
=======================================
Coverage 14.75% 14.76%
=======================================
Files 1661 1661
Lines 115525 115544 +19
Branches 35670 35681 +11
=======================================
+ Hits 17050 17059 +9
- Misses 79231 79232 +1
- Partials 19244 19253 +9
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Nov 1, 2023
…dation#5426) * feat(vehicle_cmd_gate): improve filter marker logic Signed-off-by: 1222-takeshi <[email protected]> * feat: update filtered logic Signed-off-by: 1222-takeshi <[email protected]> * chore: update README.md Signed-off-by: 1222-takeshi <[email protected]> * feat: update parameter Signed-off-by: 1222-takeshi <[email protected]> * feat: add condition for filtering marker Signed-off-by: 1222-takeshi <[email protected]> * refactor: add publishMarker function Signed-off-by: 1222-takeshi <[email protected]> --------- Signed-off-by: 1222-takeshi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following features were added in this pull request
Related links
autowarefoundation/autoware_launch#659
Tests performed
filter_activated_count_threshold_ = 5
rosbag-2023-10-27_15.46.37.mp4
filter_activated_count_threshold_ = 10
rosbag-2023-10-27_15.52.41.mp4
Notes for reviewers
Interface changes
none
Effects on system behavior
none
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.